simple-cipher: Add a test for mixed-case key#1358
Closed
tekerson wants to merge 1 commit intoexercism:masterfrom
Closed
simple-cipher: Add a test for mixed-case key#1358tekerson wants to merge 1 commit intoexercism:masterfrom
tekerson wants to merge 1 commit intoexercism:masterfrom
Conversation
The problem specification states that the key should be all lowercase, but the test data only tests for "not all uppercase".
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem specification asserts that "the key contains only lowercase letters", but the test data only tests the key is "not all uppercase".
I have already added this test to the TypeScript and JavaScript tracks. It was suggested it should be added to the canonical test data too.