saddle-point: use unambiguous coordinates#1429
Merged
kytrinyx merged 2 commits intoexercism:masterfrom Jan 6, 2019
Merged
Conversation
Member
|
What I see looks fine but I am wondering if everything addressed in #313 is fixed here. This comment stuck out to me when I quickly scanned #313 just now. If you decide to pursue re-basing the coordinate system to be 1 based the changes will spill over into the canonical data. |
Member
|
Matrix was recently updated to follow a more canonical notation for matrix indices. See #1387. |
Contributor
Author
|
Fine. As far I can see, the issue of coordinate base is orthogonal to the issue of coordinate ordering (that's why I didn't address it in this PR). I'm happy to update it to follow the Matrix example. |
petertseng
reviewed
Jan 6, 2019
| { | ||
| "row": 3, | ||
| "column": 0 | ||
| "row": 2, |
petertseng
pushed a commit
to michalfita/exercism-rust
that referenced
this pull request
Feb 15, 2019
petertseng
pushed a commit
to michalfita/exercism-rust
that referenced
this pull request
Feb 15, 2019
petertseng
pushed a commit
to michalfita/exercism-rust
that referenced
this pull request
Feb 15, 2019
petertseng
pushed a commit
to michalfita/exercism-rust
that referenced
this pull request
Feb 15, 2019
petertseng
pushed a commit
to exercism/rust
that referenced
this pull request
Nov 2, 2019
exercism/problem-specifications#1429 which was applied to this track in #789 uses one-based indices in the README. The track still uses zero-based indices in the tests. This inconsistency is a potential source of student confusion. Prevent student confusion by explaining the inconsistency. Closes #791
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The description for 'Saddle Point' illustrates what a saddle point is by showing an example matrix:
Because there are at least two completely reasonable coordinate systems which could apply here,
(1,0)is ambiguous (does it mean "column 0, row 1", which is in fact correct, or "row 1, column 0"?)This PR makes it unambiguous:
Fixes #313.
This is also a good complement to the test data, which specifies: