Clarify Rust indices from 0 in saddle-points and regenerate READMEs#900
Conversation
|
Hello @workingjubilee, thanks for contributing this! Travis has failed because it believes that the Would you please re-pull your copy of the |
24f50d3 to
845948d
Compare
|
Whoops! I failed to regenerate again with configlet after I made a teensy tiny change in-repo, actually. Fixed. |
There was a problem hiding this comment.
Sure! I am good with this solution to #791. Note that you cannot say "issue" in the line "Closes issue #791", so please remove that word. Then you will see the underline under the word "Closes" as expected.
I would like that the READMEs for other exercises either:
- Do not go in this PR at all, or
- Go in this PR, each as one commit, with links to the appropriate problem-specifications PRs that caused the corresponding change in problem-specifications.
It makes sense because, well, each commit should do a single thing, and changing other exercises's READMEs isn't to do with indexing in saddle-points. No preference as to which of those two plans of action is taken.
|
'kay! Looking around at the other exercises for the READMEs that got touched, it seems like they might need more updates anyways, so I'm just going to withdraw that change from this PR and then PR in some full updates. 💖 |
845948d to
9d0cc3e
Compare
petertseng
left a comment
There was a problem hiding this comment.
Ready to go, thank you! Other maintainers have about 48 hours to object.
Closes #791
Of the 5 choices in that issue, results of the discussion were (effectively):
"Do not do 2."
"Do 2 or 3 to be consistent with Rust."
"Do 3 for now since it is easy, then 1 later."
"1 would be possible using a little more code."
As option 2 effectively has a negative vote, and 3 has two votes for, modifying hints.md comes out as the maintainer-preferred solution. This PR implements that and regenerates the README appropriately. Or rather, READMEs. While doing so, I discovered two other READMEs were dated and their latest version was more readable, so I included them in this PR.