hello-world: Be more function-oriented, not program-oriented#322
Merged
petertseng merged 1 commit intoexercism:masterfrom Aug 7, 2016
petertseng:hello-world
Merged
hello-world: Be more function-oriented, not program-oriented#322petertseng merged 1 commit intoexercism:masterfrom petertseng:hello-world
petertseng merged 1 commit intoexercism:masterfrom
petertseng:hello-world
Conversation
| ## Specification | ||
|
|
||
| The `Hello World!` program will greet me, the caller. | ||
| Write a `Hello World!` function that takes a single input (my name) from me, the caller, and returns an appropriate string. |
Member
Author
There was a problem hiding this comment.
I think I'm going to ditch the "from me"
Contributor
|
I think these changes are definitely an improvement. |
As exercism/exercism#2746 rightfully explains, the wording of "program" implies that the student is expected to write a full program with a main function (or equivalent entry point in language of choice). Further, the wording of "greets" slightly implies that the function is expected to put the result on STDOUT. To remedy this, "program" is replaced with "function" and we specify that the function should return the greeting. Note that as #321 states, this is just one of many problems that has "write a program" in its description. However, the "greets" -> "returns" wording is an issue not covered by #321, so we deal with it here. Closes exercism/exercism#2746
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As exercism/exercism#2746 rightfully
explains, the wording of "program" implies that the student is expected
to write a full program with a main function (or equivalent entry point
in language of choice).
Further, the wording of "greets" slightly implies that the function is
expected to put the result on STDOUT.
To remedy this, "program" is replaced with "function" and we specify
that the function should return the greeting.
Note that as #321 states, this is just one of many problems that has
"write a program" in its description. However, the "greets" -> "returns"
wording is an issue not covered by #321, so we deal with it here.
Closes exercism/exercism#2746