Skip to content

sum-of-multiples: update description#476

Merged
petertseng merged 1 commit intoexercism:masterfrom
robphoenix:update/sum-of-mulitples-readme
Dec 24, 2016
Merged

sum-of-multiples: update description#476
petertseng merged 1 commit intoexercism:masterfrom
robphoenix:update/sum-of-mulitples-readme

Conversation

@robphoenix
Copy link
Copy Markdown
Contributor

description updated to mention limits,
exercism/go#340 (comment)

description updated to mention limits,
exercism/go#340 (comment)
Copy link
Copy Markdown
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good. I have one note about possible redundancy. But if nobody thinks it is useful to change, I would just merge this as-is in a day or so.


Write a program that can find the sum of the multiples of a given set of
numbers.
Write a program that, given a number, can find the sum of the multiples
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This same line is in https://github.com/exercism/x-common/blob/master/exercises/sum-of-multiples/metadata.yml#L2 - and since the blurb gets prepended to the README (I discuss at #469 (comment)), that means this line will sandwich the README.

That is still better than the current situation where the README has two contradictory lines. There is also talk of NOT prepending the blurb.

One alternative could be to remove this line completely, leaving the prepend to do the explaining. Or we could leave it. Someone may eventually request to remove the redundancy, as happened in #386

@petertseng petertseng merged commit d307c39 into exercism:master Dec 24, 2016
@robphoenix robphoenix deleted the update/sum-of-mulitples-readme branch January 3, 2017 10:21
petertseng pushed a commit that referenced this pull request Oct 10, 2017
We accepted the duplication in December 2016 in
#476

Today we decide it's better not to duplicate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants