sum-of-multiples: Removed a duplicated sentence in README#942
Merged
petertseng merged 1 commit intoexercism:masterfrom Oct 10, 2017
Merged
sum-of-multiples: Removed a duplicated sentence in README#942petertseng merged 1 commit intoexercism:masterfrom
petertseng merged 1 commit intoexercism:masterfrom
Conversation
petertseng
reviewed
Oct 10, 2017
|
|
||
| Given a number, find the sum of the multiples of a given set of numbers, | ||
| up to but not including that number. | ||
| The sum of these multiples is 78. No newline at end of file |
Member
There was a problem hiding this comment.
I would prefer that the trailing newline of line 7 does not get deleted, so that line 7 does not show as a changed line, please. Only lines 8-10 should get deleted please.
petertseng
approved these changes
Oct 10, 2017
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
Fantastic.
I don't think this needs to wait very long to merge, seems like a clearly prudent thing to do.
How did the description come to be this way? By #476 ... and I even noted in #476 (comment) that this would cause the duplicate line, but I guess nobody cared back then. Now finally someone cares, good.
Insti
approved these changes
Oct 10, 2017
petertseng
pushed a commit
to exercism/rust
that referenced
this pull request
Oct 10, 2017
petertseng
added a commit
to exercism/haskell
that referenced
this pull request
Oct 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically what the title says. I stumbled across the duplicated sentence while doing the exercises. I was sent to this repo from my first PR in the rust repo.