Skip to content

Hook schema validation in CI#658

Merged
rbasso merged 4 commits intoexercism:masterfrom
tejasbubane:schema-validation-travis
Mar 13, 2017
Merged

Hook schema validation in CI#658
rbasso merged 4 commits intoexercism:masterfrom
tejasbubane:schema-validation-travis

Conversation

@tejasbubane
Copy link
Copy Markdown
Member

@tejasbubane tejasbubane commented Mar 8, 2017

Using ajv-cli. Check canonical-data files for all exercises are compatible with the canonical-schema.

Remove jsonlint from CI since the schema validator will take care of checking malformed json.

A quick attempt to get schema validation running in CI. This does not include excluding incompatible files. Hence the build will fail until we convert all files for compatibility.

Ref: #625

@tejasbubane tejasbubane changed the title Schema validation travis Hook schema validation in CI Mar 8, 2017
@tejasbubane tejasbubane force-pushed the schema-validation-travis branch 3 times, most recently from d303a3d to f6e1ace Compare March 8, 2017 14:06
@petertseng
Copy link
Copy Markdown
Member

petertseng commented Mar 9, 2017

I'd request that this PR also edit https://github.com/exercism/x-common#automated-tests

Using [ajv-cli](https://github.com/jessedc/ajv-cli). Check
canonical-data files for all exercises are compatible with
the canonical-schema.
Remove jsonlint since the schema validator will take care of checking
validating malformed json.
@tejasbubane tejasbubane force-pushed the schema-validation-travis branch from f6e1ace to 55ccad0 Compare March 12, 2017 11:36
@tejasbubane tejasbubane force-pushed the schema-validation-travis branch from 55ccad0 to 02582ce Compare March 12, 2017 11:41
@tejasbubane
Copy link
Copy Markdown
Member Author

Added instructions to the README. Only 2 more exercises to go! 😄 👍

Copy link
Copy Markdown
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's time.

@rbasso rbasso merged commit e797c50 into exercism:master Mar 13, 2017
@tejasbubane tejasbubane deleted the schema-validation-travis branch March 13, 2017 06:44
emcoding pushed a commit that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants