Hook schema validation in CI#658
Merged
rbasso merged 4 commits intoexercism:masterfrom Mar 13, 2017
Merged
Conversation
d303a3d to
f6e1ace
Compare
Member
|
I'd request that this PR also edit https://github.com/exercism/x-common#automated-tests |
75 tasks
Using [ajv-cli](https://github.com/jessedc/ajv-cli). Check canonical-data files for all exercises are compatible with the canonical-schema.
Remove jsonlint since the schema validator will take care of checking validating malformed json.
f6e1ace to
55ccad0
Compare
55ccad0 to
02582ce
Compare
Member
Author
|
Added instructions to the README. Only 2 more exercises to go! 😄 👍 |
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
sum-of-multiples: added generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using ajv-cli. Check canonical-data files for all exercises are compatible with the canonical-schema.
Remove
jsonlintfrom CI since the schema validator will take care of checking malformed json.A quick attempt to get schema validation running in CI. This does not include excluding incompatible files. Hence the build will fail until we convert all files for compatibility.
Ref: #625