Conversation
| "some languages demonstrate the add function by inviting the", | ||
| "solver to include their birthdate in either the solution code", | ||
| "or test program. The test program then shows or tests their", | ||
| "gigasecond anniversay." |
There was a problem hiding this comment.
Yeah... saw that... not a compliance change though... so I left it. I guess it wouldn't hurt...
tejasbubane
left a comment
tejasbubane
left a comment
There was a problem hiding this comment.
Looks good! One small typo in "comments".
kotp
force-pushed
the
gigasecond_make-exercise-schema-compliant
branch
from
98e4ce9 to
614a9b5
Compare
| "cases": [ | ||
| { | ||
| "add": | ||
| { |
There was a problem hiding this comment.
Please don't merge it yet. It certainly isn't compliant!
There was a problem hiding this comment.
I'm not sure if it is needed. We can add another commit soon.
There was a problem hiding this comment.
Hmm... yeah, I did check the travis-ci result, it was passing the local test... revert it, and let's see what I missed.
There was a problem hiding this comment.
This one was trick. It needed:
- Descriptions for each test case - ☑️
- Properties for each test case (I would have used
addinstead ofinteger) ☑️ - Transforming the list of strings in the group
descriptionin a single string. ❌ (you did it, but you changed it to a comment. - Remove the
addobject. ❌
There was a problem hiding this comment.
I verified what happened locally, I did stash, changed my local $EXERCISE value to review a different exercise, and verified it, merged it, grabbed the changes, went back to my branch, rebased it on master, unstashed my changes, forgot to reassign my exercise environment variable and then had it pass... of course...
So process error.
Remove leading 'x' from repository name
5 participants
ref: #625