palindrome-product: Clarify requirements#897
Merged
jpreese merged 3 commits intoexercism:masterfrom Sep 20, 2017
Merged
Conversation
REF exercism/ruby#305 It's not clear from the current examples what the requirements of this exercise are. In fact, a furtive glance is more likely to cause confusion than give clarity. In my opinion, this is because for the first example the solution lies within the range of the list of factors, giving on a first impression that we are looking for products that lie within this range. I think that by listing out the entire list of products (which is small in the case of the range of 1..9) we make it more clear that we are considering all the results.
10 tasks
Insti
reviewed
Sep 11, 2017
| `[1, 2, 3, 4, 5, 6, 7, 8, 9]` | ||
|
|
||
| The smallest palindrome product is `1`. It's factors are `(1, 1)`. | ||
| The largest palindrome product is `9`. It's factors are `(1, 9)`, `(3, 3)`, and `(9, 1)`. |
Contributor
|
Looks good 👍 |
Contributor
|
Once this is merged it would be great if you would create an issue or a PR back in the exercism/ruby repository about updating the readme from the updated common description. There is some documentation about how to use Edit: I meant to post this as a reply to exercism/ruby#723, updated to make sense in this context. 😊 |
Insti
changed the title
Contributor
Author
|
Sure, I'll give that a try once this merged. |
Insti
reviewed
Sep 11, 2017
| `[1, 2, 3, 4, 5, 6, 7, 8, 9]` | ||
|
|
||
| The smallest palindrome product is `1`. Its factors are `(1, 1)`. | ||
| The largest palindrome product is `9`. Its factors are `(1, 9)`, `(3, 3)`, and `(9, 1)`. |
Contributor
There was a problem hiding this comment.
The tests only expect (1,9) and (3,3) as factors.
(and always seem to expect factor pairs in (lowest, highest) order.
Contributor
Author
There was a problem hiding this comment.
Good point... I forgot I had to sort and uniq my results. I'll udpdate.
The tests do not distinguish between `(a, b)` and `(b, c)`.
ErikSchierboom
approved these changes
Sep 12, 2017
jpreese
approved these changes
Sep 20, 2017
Contributor
|
Thanks @dkinzer 🎉 ! |
shaleh
pushed a commit
to shaleh/exercism-problem-specifications
that referenced
this pull request
Sep 21, 2017
* Clarify palindrome product exercise requirements REF exercism/ruby#305 It's not clear from the current examples what the requirements of this exercise are. In fact, a furtive glance is more likely to cause confusion than give clarity. In my opinion, this is because for the first example the solution lies within the range of the list of factors, giving on a first impression that we are looking for products that lie within this range. I think that by listing out the entire list of products (which is small in the case of the range of 1..9) we make it more clear that we are considering all the results. * Fix typo. * Update palindrome-products factors examples. The tests do not distinguish between `(a, b)` and `(b, c)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REF exercism/ruby#305
REF exercism/ruby#723
It's not clear from the current examples what the requirements of this exercise are. In fact, a furtive glance is more likely to cause confusion than give clarity.
In my opinion, this is because for the first example the solution lies within the range of the list of factors, giving on a first impression that we are looking for products that lie within this range.
I think that by listing out the entire list of products (which is small in the case of the range of 1..9) we make it more clear that we are considering all the results.