Clarify palindrome product exercise requirements#723
Closed
dkinzer wants to merge 1 commit intoexercism:masterfrom
Closed
Clarify palindrome product exercise requirements#723dkinzer wants to merge 1 commit intoexercism:masterfrom
dkinzer wants to merge 1 commit intoexercism:masterfrom
Conversation
REF exercism#305 It's not clear from the current examples what the requirements of this exercise are. In fact, a furtive glance is more likely to cause confusion than give clarity. In my opinion, this is because for the first example the solution lies within the range of the list of factors, giving on a first impression that we are looking for products that lie within this range. I think that by listing out the entire list of products (which is small in the case of the range of 1..9) we make it more clear that we are considering all the results.
Contributor
|
I like this. 👍 Would you be willing to make a PR against the common problem definition: From which this README is generated. Thanks. |
Contributor
|
They've also fixed the |
Insti
reviewed
Sep 11, 2017
| The largest product is `9`. It's factors are `(1, 9)`, `(3, 3)`, and `(9, 1)`. | ||
| And given the list of all possible products within this range: | ||
| `[1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 12, 14, 16, 18, 15, 21, 24, 27, 20, 28, 32, 36, 25, 30, 35, 40, 45, 42, 48, 54, 49, 56, 63, 64, 72, 81]` | ||
|
|
Contributor
There was a problem hiding this comment.
It might also be handy to add a line identifying the palindromic products and noting explicitly there are no 2 digit palindromes.
Contributor
Author
|
Closing in favor of exercism/problem-specifications#897 |
Contributor
|
Great, thanks. ❤️ |
Contributor
|
There are some more clues about regenerating READMEs here: #722 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REF #305
It's not clear from the current examples what the requirements of this exercise are. In fact, a furtive glance is more likely to cause confusion than give clarity.
In my opinion, this is because for the first example the solution lies within the range of the list of factors, giving on a first impression that we are looking for products that lie within this range.
I think that by listing out the entire list of products (which is small in the case of the range of 1..9) we make it more clear that we are considering all the results.
Types of changes
References and Closures
Checklist: