kindergarten-garden: grammatical improvements to description.md#948
kindergarten-garden: grammatical improvements to description.md#948rpottsoh merged 3 commits intoexercism:masterfrom
Conversation
| They've chosen to grow grass, clover, radishes, and violets. | ||
|
|
||
| To this end, they've put little styrofoam cups along the window sills, | ||
| To this end, they've put little Styrofoam cups along the window sills, |
There was a problem hiding this comment.
I'd rather see a generic term used here. plastic? paper?
Can we just omit the word Styrofoam?
And does it matter they are little?
And since I'd grow a plant in a pot, how about a simply:
"they've put pots along the window sills"
There was a problem hiding this comment.
Plastic cups should suffice. I'll make the change.
There was a problem hiding this comment.
Whatever we do decide here, we should then change other occurences of “cups” as well. And since I had to google “Styrofoam”, I'd say we should stick to something much more generic like “pot” or “planting pot”.
| - Eve, Fred, Ginny, Harriet, | ||
| - Ileana, Joseph, Kincaid, and Larry. | ||
|
|
||
| Each child gets 4 cups, two on each row. The children are assigned to |
There was a problem hiding this comment.
Removing this 'to' changes the meaning of the sentence.
It probably needs a more comprehensive rewording.
There was a problem hiding this comment.
Are the children alphabetized or the cups? If it is the cups then I didn't pay close enough attention to how the exercise is intended to operate. If it is referring to the children then the to should be dropped. I'll look this over again as well.
This commit contains requested changes to original commit as well as some other changes that I felt needed to be made.
| responsible for. | ||
|
|
||
| The kindergarten class is learning about growing plants. The teachers | ||
| The kindergarten class is learning about growing plants. The teacher |
There was a problem hiding this comment.
Unnecessary change, kindergarten classes often have multiple teachers.
That said, I don't really care or think it matters whether we use singular or plural here. (apart from consistency throughout the rest of the description.)
| ```text | ||
| [window][window][window] | ||
| ........................ # each dot represents a Styrofoam cup | ||
| ........................ # each dot represents a cup location |
There was a problem hiding this comment.
"location" is redundant here.
The usage also grates a little with me, since location is about where something is.
Q: What does this dot represent? .
a) A cup
b) A cup location.
if b, where is the cup located?
There was a problem hiding this comment.
I agree with you here. I was on the fence about adding location. Kinda felt right, kinda didn't, so I thought I would try it on for size. :) I will remove it.
| Each child gets 4 cups, two on each row. The children are assigned | ||
| cups in alphabetical order. | ||
| Each child gets 4 cups, two on each row. Their teacher assigns cups to | ||
| the children alphabetically by their names. |
There was a problem hiding this comment.
I didn't go with my first draft of the new sentence:
The evil nun assigned cups to the children alphabetically by their names.
Then I would just have to replace teacher everywhere. 👅
| So in the row nearest the window, she has a violet and a radish; in the | ||
| row behind that, she has a radish and some grass. | ||
| In the row nearest the window, she has a violet and a radish. In the | ||
| second row she has a radish and some grass. |
There was a problem hiding this comment.
"first" and "second" are used as a pair, but there is no "first".
"In the other row"?
or
"In the first row nearest the window"
Changes made based on feedback
|
@Insti I have made the changes as you suggested, thanks. I'll let this sit for awhile and will squash merge it later if no one has any further changes to suggest. |
rpottsoh
changed the title
3 participants
No description provided.