Skip to content

description.md: rm trailing spaces#995

Merged
petertseng merged 1 commit intoexercism:masterfrom
petertseng:trailing-spaces
Nov 4, 2017
Merged

description.md: rm trailing spaces#995
petertseng merged 1 commit intoexercism:masterfrom
petertseng:trailing-spaces

Conversation

@petertseng
Copy link
Copy Markdown
Member

One might assume that we can consider a CI check that there are no
trailing spaces, but we have to be careful because some embedded strings
that serve as example outputs are expected to have trailing spaces. The
currently only example is ocr-numbers. One might consider a CI check,
but simply exclude that file.

One might assume that we can consider a CI check that there are no
trailing spaces, but we have to be careful because some embedded strings
that serve as example outputs are expected to have trailing spaces. The
currently only example is ocr-numbers. One might consider a CI check,
but simply exclude that file.
Copy link
Copy Markdown
Member

@rpottsoh rpottsoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

They've chosen to grow grass, clover, radishes, and violets.

To this end, the children have put little cups along the window sills, and
planted one type of plant in each cup, choosing randomly from the available
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, that's my handy work from #948. My bad! Thanks @petertseng

- Ileana, Joseph, Kincaid, and Larry.

Each child gets 4 cups, two on each row. Their teacher assigns cups to
Each child gets 4 cups, two on each row. Their teacher assigns cups to
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as before

@petertseng
Copy link
Copy Markdown
Member Author

OK, the only one of these that I think is potentially controversial is the rectangles one. The spaces make it so that each line in the individual-rectangle diagrams is the same length as each line in the original diagram. I don't think this is necessary because it's for human consumption and does not in any way indicate what the output should look like (the output is a number!) so I still think I'm justified. So I am not really thinking I should wait on this one.

We did remove trailing whitespace in 33d9ada though I also note that that commit did not remove the trailing whitespace on rectangle when it had a chance to do so! So, potentially deliberate! But I have stated my reason.

@petertseng petertseng merged commit f5dc499 into exercism:master Nov 4, 2017
@petertseng petertseng deleted the trailing-spaces branch November 4, 2017 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants