Added test_is_valid_can_be_called_repeatedly() to the test set.#136
Merged
kytrinyx merged 1 commit intoexercism:masterfrom Oct 21, 2014
mmakaay:master
Merged
Added test_is_valid_can_be_called_repeatedly() to the test set.#136kytrinyx merged 1 commit intoexercism:masterfrom mmakaay:master
kytrinyx merged 1 commit intoexercism:masterfrom
mmakaay:master
Conversation
This test checks if is_valid() can be called multiple times. Many implementations failed for this, because a list of digits that was created at init time, got mangled by the Luhn transformation, causing the second call to is_valid() to work with different input data.
Member
|
Mutability is hard :) Thank you. |
kytrinyx
added a commit
that referenced
this pull request
Oct 21, 2014
Added test_is_valid_can_be_called_repeatedly() to the test set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test checks if is_valid() can be called multiple times.
Many implementations failed for this, because a list of digits
that was created at init time, got mangled by the Luhn
transformation, causing the second call to is_valid() to
work with different input data.