luhn: Update tests and example#409
Merged
behrtam merged 5 commits intoexercism:masterfrom Mar 9, 2017
rootulp:luhn/tests
Merged
luhn: Update tests and example#409behrtam merged 5 commits intoexercism:masterfrom rootulp:luhn/tests
behrtam merged 5 commits intoexercism:masterfrom
rootulp:luhn/tests
Conversation
Contributor
rootulp
commented
Jan 29, 2017
rootulp
commented
- References Changes to Luhn tests #402
added 2 commits
January 29, 2017 18:15
- implement new tests as described in: https://github.com/exercism/x-common/blob/master/exercises/luhn/canonical-data.json
Contributor
|
We should keep an eye on those |
Contributor
Author
|
Good point. I expect the canonical-data to change so we should keep this open until that gets resolved. |
Contributor
Contributor
Author
|
@behrtam sorry for the slow response! I updated the canonical tests. |
behrtam
reviewed
Mar 8, 2017
| def test_more_than_a_single_zero_is_valid(self): | ||
| self.assertTrue(Luhn("0000 0").is_valid()) | ||
|
|
||
| def test_is_valid_can_be_called_repeatedly(self): |
Contributor
There was a problem hiding this comment.
I would like to leave this mutability test case (#136) as it is.
Maybe we could put it as the last test with a comment (# additional track specific test case).
Contributor
Author
There was a problem hiding this comment.
Added back with the comment you suggested. I replaced the test value with "055 444 285" because it exists in the canonical data.
Contributor
|
Thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.