Add test for saddle points in row#1427
Conversation
There is a test for multiple saddle points in a column, but no test for multiple points in a row.
Test for multiple saddle points in the same column renamed similar to that for multiple points in a row
|
Hi, thanks for the PR! The way we have things structured here, any test suite containing the following comment are merely implementations of the global canonical data. We usually try to avoid adding tests that are not found there. However, I think this is a good test idea, so I would suggest creating a PR over at https://github.com/exercism/problem-specifications to add this case there. Once that PR is merged, this one may be updated to match the new canonical data version and merged here. # Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0 |
|
Awaiting merge of exercism/problem-specifications#1272. |
cmccandless
left a comment
cmccandless
left a comment
There was a problem hiding this comment.
Changes look good. Please update the referenced canonical data version and this PR will be ready to merge
* update the version of referenced canonical-data.json * make test-data of new test same as that in referenced canonical-data.json
|
Reference updated. I also harmonized the test data in the new test to perfectly match that of the canonical data specification. |
|
Merged; thanks for working on this! |
2 participants
There is a test for multiple saddle points in a column, but there is no test for multiple points in a row.
These changes rename the existing test to indicate it tests for saddle points in a column and adds a test for multiple points in a row.