Skip to content

Add test for saddle points in row #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmccandless merged 3 commits into from
Jul 27, 2018
Merged

Add test for saddle points in row #1427

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0139e35
saddle-point: Add missing test
DocFogel Jul 22, 2018
5709a64
saddle-point: Clarify test name
DocFogel Jul 22, 2018
6680f8e
saddle-point: Update reference to canonical-data
DocFogel Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions exercises/saddle-points/saddle_points_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from saddle_points import saddle_points


# Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0
# Tests adapted from `problem-specifications//canonical-data.json` @ v1.2.0

class SaddlePointsTest(unittest.TestCase):
def test_identify_single_saddle_point(self):
Expand All @@ -24,11 +24,16 @@ def test_identify_lack_of_saddle_points_when_there_are_none(self):
matrix = [[1, 2, 3], [3, 1, 2], [2, 3, 1]]
self.assertEqual(saddle_points(matrix), set())

def test_identify_multiple_saddle_points(self):
def test_identify_multiple_saddle_points_in_column(self):
matrix = [[4, 5, 4], [3, 5, 5], [1, 5, 4]]
expected = set([(0, 1), (1, 1), (2, 1)])
self.assertEqual(saddle_points(matrix), expected)

def test_identify_multiple_saddle_points_in_row(self):
matrix = [[6, 7, 8], [5, 5, 5], [7, 5, 6]]
expected = set([(1, 0), (1, 1), (1, 2)])
self.assertEqual(saddle_points(matrix), expected)

def test_identify_saddle_point_in_bottom_right_corner(self):
matrix = [[8, 7, 9], [6, 7, 6], [3, 2, 5]]
expected = set([(2, 2)])
Expand Down