sum-of-multiples: Implemented issue #141#147
sum-of-multiples: Implemented issue #141#147Dog wants to merge 1 commit intoexercism:masterfrom Dog:master
Conversation
|
Is there an issue with this implementation? |
|
I think this just slipped through the cracks. Thanks for pinging! @sjakobi would you sanity-check this when you have a moment? |
|
I generally merge things locally when there are conflicts. I would suggest merging #139 and then you can do this locally:
which will make sure that you have a fresh master as well as a local branch with the pull request in it. Then you can run The other option is to merge one and ask the other author to rebase onto the new master and resolve commits :) I will generally go this route if I'm unsure of how I would resolve the conflicts. |
|
No problem. I had a feeling if there was an issue someone would have commented. I'm still getting accustomed to working on Github though. Thanks |
|
This is closed by #149, I think. If I'm wrong, please reopen this! |
Implemented issue #141 which requested that sum_of_multiples use a function rather than a class.
I implemented the multiples as a list because it made it easier to differentiate them from the limit when looking at the test file. In the example I set the default multiples to None to avoid a python gotcha with mutable default arguments.
http://docs.python-guide.org/en/latest/writing/gotchas/