sum-of-multiples: Move to functional solution, add tests#149
Merged
kytrinyx merged 3 commits intoexercism:masterfrom Nov 24, 2014
sjakobi:fix-sum-of-multiples
Merged
sum-of-multiples: Move to functional solution, add tests#149kytrinyx merged 3 commits intoexercism:masterfrom sjakobi:fix-sum-of-multiples
kytrinyx merged 3 commits intoexercism:masterfrom
sjakobi:fix-sum-of-multiples
Conversation
Contributor
Author
Contributor
|
My initial concern is I think the example assumes zero is the first multiple in the list. I'll try to play with it later tonight. |
Contributor
Author
That should be ok under the assumptions given in the test file (the input factors are non-negative, unique and sorted in ascending order). |
Contributor
|
Then it looks good to me. |
kytrinyx
added a commit
that referenced
this pull request
Nov 24, 2014
sum-of-multiples: Move to functional solution, add tests
Member
|
Thanks, everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #139, #147.