Rubocop: Enable space after comma cop#542
Merged
kotp merged 2 commits intoexercism:masterfrom Jan 17, 2017
Merged
Conversation
Insti
changed the title
Member
|
Will the rubocop change impact current code? |
Contributor
Author
There are 15 files that fail this check, they are fixed in the second commit of this PR: bed3b50 |
Member
|
Should the rubocop config file exclude the example.rb files? You know I like to tread lightly on the example files, as they are "Proof of Solvability", and not necessarily optimal or idiomatic. |
Contributor
Author
No. It's good for the entire repository to have a consistent style. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kotp flagged a missing space after comma in a review: #540 (review)
This patch enables the Style/SpaceAfterComma cop so that this can be automatically detected and fixed by Rubocop.