generator: refactor implementation, part 2 - extract Repository#678
Merged
Insti merged 6 commits intoexercism:masterfrom Jun 30, 2017
Merged
generator: refactor implementation, part 2 - extract Repository#678Insti merged 6 commits intoexercism:masterfrom
Insti merged 6 commits intoexercism:masterfrom
Conversation
Contributor
Author
|
Build failed due to Rubocop check for SpaceAfterComma. Why is Rubocop complaining, I thought it was disabled. :/ Hmm, I enabled this one: #542 - ok seems sensible. Fixed and force-pushed the updated version. |
Since we're using `slug` to identify a problem we can remove some now unnecessary references to `Exercise`
Implementation should get everything it needs to know about from a Repostiory. There are some knock-on effects on source_filepath
Insti
force-pushed
the
Repository_extraction
branch
from
b3b0f44 to
f43b807
Compare
Insti
commented
Jun 13, 2017
| def initialize | ||
| @paths = FixturePaths | ||
| @exercise = Exercise.new(slug: 'notemplate') | ||
| @slug = 'no-template' |
Contributor
Author
There was a problem hiding this comment.
Added a hyphen so we don't need to worry about whether it's an emplate or not.
kotp
approved these changes
Jun 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract a
Repositoryclass that takespathsandslugas constructor arguments.Repository in this case is an implementation of the Repository pattern which acts as an interface to all the data that an
Implementationneeds rather than anything related to Git repositories.Continues the work done in #677,
Supersedes #643