generator: refactor implementation, part 1 highlights.#677
Merged
Insti merged 5 commits intoexercism:masterfrom Jun 13, 2017
Merged
generator: refactor implementation, part 1 highlights.#677Insti merged 5 commits intoexercism:masterfrom
Insti merged 5 commits intoexercism:masterfrom
Conversation
leftover from the proc days
Two reasons. Main reason: Implementation shouldn't be thinking in terms of files. Secondary reason, old name was misleading, as it regenerates the file when it exists :(
kotp
reviewed
Jun 13, 2017
| def initialize | ||
| @paths = FixturePaths | ||
| @slug = 'notemplate' | ||
| @exercise = Exercise.new(slug: 'notemplate') |
Member
There was a problem hiding this comment.
Is there room here to use 'no template' or if necessary 'no_template'?
Contributor
Author
There was a problem hiding this comment.
Probably. It would need to be no-template. This will need to happen later though as I'm trying not to mess with the pre-existing commits.
kotp
approved these changes
Jun 13, 2017
Member
kotp
left a comment
kotp
left a comment
There was a problem hiding this comment.
This looks really good. Glad these are being continued on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #641 - generator: refactor implementation, part 1, Hilary started some generator refactorings. Progress on this seems to have stopped.
In order to continue the refactoring I have extracted from the uncontroversial changes from the initial PR.
I have further built upon these changes to continue the refactoring. (To follow in further PRs.)