[WIP] generator: part 2 (version b) of refactor implementation model#643
Closed
hilary wants to merge 12 commits intoexercism:masterfrom
Closed
[WIP] generator: part 2 (version b) of refactor implementation model#643hilary wants to merge 12 commits intoexercism:masterfrom
hilary wants to merge 12 commits intoexercism:masterfrom
Conversation
#available shouldn't depend on the existence of a '<mumble>_case.rb' file, because that might go away or get changed. We can just look for the presence of a .meta/generator directory.
leftover from the proc days
Two reasons. Main reason: Implementation shouldn't be thinking in terms of files. Secondary reason, old name was misleading, as it regenerates the file when it exists :(
I like this version far better It's a really clean transition until we get into GeneratorCases. I think the reason it got uglier in GeneratorCases is because that module is problematic.
a consolidation before we get into the files stuff seriously
Insti
reviewed
May 15, 2017
| end | ||
|
|
||
| def test_update_tests_version | ||
| # Minitest::Mock doesn't document how to allow the mocked method to be called twice |
Contributor
There was a problem hiding this comment.
You just add another expectation.
mock.expect :do_something, 'once'
mock.expect :do_something, 'twice'
But you're right about it not being documented :/
Insti
changed the title
Contributor
|
The extraction of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second version of part 2 of #641
This version instantiates Repository with paths and exercise.