isogram: update solution to pass current tests.#669
Conversation
|
|
||
| class Isogram | ||
| def self.is_isogram?(str) | ||
| def self.isogram?(str) |
There was a problem hiding this comment.
Do use "string" as a name. Better use phrase or word or whatever the most general "language" thing is that is wanted, rather than a programming thing.
Yet, even without that change, the example is not shown actively, so it would be acceptable to the "the problem is solvable in this language" goal.
There was a problem hiding this comment.
Oh, you were commenting on an aspect of the example solution that has not been changed as part of this PR.
This PR is just trying to make the existing example pass the current tests, if you want to improve the example solution this can be done in another PR.
|
Sorry I should have caught that as well, that's my fault. |
|
@deohtee are you running the git hooks when you develop these? |
|
I am not. Is there any documentation on it? I tried looking for some just now but couldn't find any |
|
The git hooks are not necessary to trigger Travis CI - only for local checks. |
|
@deohtee the git hook documentation is here: https://github.com/exercism/xruby#pull-requests |
|
Right... the hooks locally though can help contributors confirm the tests... |
3 participants
#664 updated the
isogramtests but not the example solution.For some reason Travis CI, which would have detected this, did not run on that PR.
This patch updates the example solution to pass the updated tests.