Skip to content

isogram: update solution to pass current tests. #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Insti merged 1 commit into from
Jun 8, 2017
Merged

isogram: update solution to pass current tests. #669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exercises/isogram/.meta/solutions/isogram.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module BookKeeping
VERSION = 3
VERSION = 4
end

class Isogram
def self.is_isogram?(str)
def self.isogram?(str)
Copy link
Copy Markdown
Member

@kotp kotp Jun 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do use "string" as a name. Better use phrase or word or whatever the most general "language" thing is that is wanted, rather than a programming thing.

Yet, even without that change, the example is not shown actively, so it would be acceptable to the "the problem is solvable in this language" goal.

Copy link
Copy Markdown
Contributor Author

@Insti Insti Jun 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

Copy link
Copy Markdown
Member

@kotp kotp Jun 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The argument name.

Copy link
Copy Markdown
Contributor Author

@Insti Insti Jun 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you were commenting on an aspect of the example solution that has not been changed as part of this PR.

This PR is just trying to make the existing example pass the current tests, if you want to improve the example solution this can be done in another PR.

letters = str.downcase.gsub(/[[:punct:]]| /, '').chars
letters == letters.uniq
end
Expand Down