nucleotide-codons: rm unneeded return#1003
Merged
petertseng merged 1 commit intoexercism:masterfrom Nov 17, 2020
petertseng:return
Merged
nucleotide-codons: rm unneeded return#1003petertseng merged 1 commit intoexercism:masterfrom petertseng:return
petertseng merged 1 commit intoexercism:masterfrom
petertseng:return
Conversation
clippy: warning: unneeded `return` statement note: `#[warn(clippy::needless_return)]` on by default help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return Removing the `return` and semicolon will make the code more rusty. I understand this exercise is deprecated and that we already did this to protein-translation in 3d3cd9a. Clippy doesn't know this when we run it against all the exercises, so might as well just do this to get closer to zero Clippy warnings in tests (which we are pretty close to)
coriolinus
approved these changes
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clippy:
warning: unneeded
returnstatementnote:
#[warn(clippy::needless_return)]on by defaulthelp: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
Removing the
returnand semicolon will make the code more rusty.I understand this exercise is deprecated and that we already did this to
protein-translation in 3d3cd9a.
Clippy doesn't know this when we run it against all the exercises, so
might as well just do this to get closer to zero Clippy warnings in
tests (which we are pretty close to)