replace TRAVIS_PULL_REQUEST with GITHUB_EVENT_NAME#1007
replace TRAVIS_PULL_REQUEST with GITHUB_EVENT_NAME#1007petertseng merged 3 commits intoexercism:masterfrom petertseng:travis
Conversation
When moving off of Travis in #975, there were some instances of TRAVIS_PULL_REQUEST left over as a transitionary strategy. Now we have been hurt by leaving TRAVIS_PULL_REQUEST in: In #1006 a new GitHub Actions job was added that forgot to set TRAVIS_PULL_REQUEST and caused incorrect behaviour. So let's remove TRAVIS_PULL_REQUEST and instead change it to GITHUB_EVENT_NAME. Documentation: https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables
This reverts commit 58af7b0.
|
Apologies, maintainers-admin. my proof commit should have targeted config.json instead. Since I removed the change to config/maintainers.json, your review is not needed. Apologies and thanks for bearing with me. |
|
After this was merged, at this point master's CI fails as desired: https://github.com/exercism/rust/actions/runs/368482577, good. Time to merge #1003 now. |
|
I suppose the commit message glossed over a few instances of behaviour changes in two scripts. I'm sure they were indeed noticed in review, but I will detail them here for anyone who was not a reviewer and is coming to it after the fact:
My bad for forgetting to include this in the commit message. One could argue that it's part and parcel of moving off of Travis: the previous "last 7 days" rules assumed that the |
When moving off of Travis in
#975, there were some instances of
TRAVIS_PULL_REQUEST left over as a transitionary strategy.
Now we have been hurt by leaving TRAVIS_PULL_REQUEST in:
In #1006 a new GitHub Actions job
was added that forgot to set TRAVIS_PULL_REQUEST and caused incorrect
behaviour.
So let's remove TRAVIS_PULL_REQUEST and instead change it to
GITHUB_EVENT_NAME.
Documentation:
https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables