anagram, pythagorean-triplet: use collect() instead of from_iter()#1027
Merged
petertseng merged 1 commit intoexercism:masterfrom Nov 20, 2020
petertseng:collect
Merged
anagram, pythagorean-triplet: use collect() instead of from_iter()#1027petertseng merged 1 commit intoexercism:masterfrom petertseng:collect
petertseng merged 1 commit intoexercism:masterfrom
petertseng:collect
Conversation
https://rust-lang.github.io/rust-clippy/master/index.html#from_iter_instead_of_collect Apparently it should be rare to call `from_iter()` directly. This lint is a fairly recent addition (merged 17 days ago): rust-lang/rust-clippy@a2bf404 Observing that the necessary code change still works on 1.47.0 (note that 1.48.0 was released very recently), it seems safe to make the change now.
This was referenced Nov 20, 2020
coriolinus
approved these changes
Nov 20, 2020
petertseng
added a commit
that referenced
this pull request
Nov 21, 2020
Same idea as #1027 but for examples not stubs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://rust-lang.github.io/rust-clippy/master/index.html#from_iter_instead_of_collect
Apparently it should be rare to call
from_iter()directly.This lint is a fairly recent addition (merged 17 days ago):
rust-lang/rust-clippy@a2bf404
Observing that the necessary code change still works on 1.47.0 (note
that 1.48.0 was released very recently), it seems safe to make the
change now.