ensure-stubs-compile: Deny all warnings except new_without_default#1030
Merged
petertseng merged 1 commit intoexercism:masterfrom Nov 20, 2020
petertseng:clippy-stub-deny
Merged
ensure-stubs-compile: Deny all warnings except new_without_default#1030petertseng merged 1 commit intoexercism:masterfrom petertseng:clippy-stub-deny
petertseng merged 1 commit intoexercism:masterfrom
petertseng:clippy-stub-deny
Conversation
We don't find it too useful to have students implement Default. All other warnings in stubs have been dealt with, and we find it useful to ensure there are no further ones. Closes #659 This is appropriate because: * stubs and tests are now ensured to have no Clippy warnings or errors * examples are ensured to have no errors, and we're unconcerned about them having warnings since students don't see them * rustfmt is enforced
Member
Author
Well, we should discuss that, since by "we" right now I just mean "I". |
Member
So, I'm a little conflicted about this, because clippy's recommendation is in fact good practice. In general, it's nice to be able to grab a I am therefore convinced that it is not very useful to have students implement |
coriolinus
approved these changes
Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't find it too useful to have students implement Default.
All other warnings in stubs have been dealt with, and we find it useful
to ensure there are no further ones.
I've determined via https://github.com/petertseng/exercism-rust/actions/runs/373860276 that when #1027, #1028, #1029, and this are merged, there are no more Clippy warnings or errors in stubs.
Closes #659
This is appropriate because:
them having warnings since students don't see them