doubly-linked-list: Allow should_implement_trait#1029
Merged
petertseng merged 2 commits intoexercism:masterfrom Nov 20, 2020
petertseng:clipnext
Merged
doubly-linked-list: Allow should_implement_trait#1029petertseng merged 2 commits intoexercism:masterfrom petertseng:clipnext
petertseng merged 2 commits intoexercism:masterfrom
petertseng:clipnext
Conversation
It's understandable that clippy says the `next` here conflicts with Iterator's `next`, but I really think that's the best name for it unless we go with something like `forward` and `back`. There is one other example of Cursors on the internet: https://contain-rs.github.io/linked-list/linked_list/struct.Cursor.html This one also uses `next`, so it seems they did not find a better solution to this than we could. Helps address #1011 Helps address #1012
Member
Author
|
I have changed my mind since saying "I think it'd be weird to distribute this attribute to students". I think it's fine. Maybe it'll get them curious about Clippy. |
coriolinus
approved these changes
Nov 20, 2020
Member
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
I don't feel strongly one way or the other about whether it's weird to show this annotation to students. We already recommend clippy in every readme file, so they should at least be aware that it's a thing. Once a student has reached the point of implementing doubly-linked list, I think it's unlikely that they'll never have seen anything like this before.
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's understandable that clippy says the
nexthere conflicts withIterator's
next, but I really think that's the best name for it unlesswe go with something like
forwardandback.There is one other example of Cursors on the internet:
https://contain-rs.github.io/linked-list/linked_list/struct.Cursor.html
This one also uses
next, so it seems they did not find a bettersolution to this than we could.
Helps address #1011
Helps address #1012