DO NOT MERGE: Deny clippy warnings in example solutions#1012
Closed
petertseng wants to merge 3 commits intoexercism:masterfrom
petertseng:clippy-ex
Closed
DO NOT MERGE: Deny clippy warnings in example solutions#1012petertseng wants to merge 3 commits intoexercism:masterfrom petertseng:clippy-ex
petertseng wants to merge 3 commits intoexercism:masterfrom
petertseng:clippy-ex
Conversation
Member
Author
Will consider fixing some of these at some point, but don't really find it urgent. |
This was referenced Nov 18, 2020
Member
|
At this point all lints with more than 2 errors reported should be fixed. |
The author isn't really interested in prioritising these but wants to at least take a look at how the situation is.
Member
Author
|
Yes, that is true! Excellent. (updated after #1025) |
This was referenced Nov 18, 2020
petertseng
added a commit
that referenced
this pull request
Nov 18, 2020
clippy::needless_collect Instead, check whether element exists in collection during iteration. Helps address #1012
petertseng
added a commit
that referenced
this pull request
Nov 18, 2020
clippy::filter_next https://rust-lang.github.io/rust-clippy/master/index.html#filter_next Helps address #1012
petertseng
added a commit
that referenced
this pull request
Nov 18, 2020
clippy::same_item_push https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push Helps address #1012
petertseng
added a commit
that referenced
this pull request
Nov 20, 2020
It's understandable that clippy says the `next` here conflicts with Iterator's `next`, but I really think that's the best name for it unless we go with something like `forward` and `back`. There is one other example of Cursors on the internet: https://contain-rs.github.io/linked-list/linked_list/struct.Cursor.html This one also uses `next`, so it seems they did not find a better solution to this than we could. Helps address #1011 Helps address #1012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author isn't really interested in prioritising these but wants to
at least take a look at how the situation is.