GitHub Actions: Run Clippy on stubs#1011
Merged
petertseng merged 7 commits intoexercism:masterfrom Nov 18, 2020
petertseng:clippy-stub
Merged
GitHub Actions: Run Clippy on stubs#1011petertseng merged 7 commits intoexercism:masterfrom petertseng:clippy-stub
petertseng merged 7 commits intoexercism:masterfrom
petertseng:clippy-stub
Conversation
petertseng
commented
Nov 18, 2020
Fails the build if any stubs have Clippy errors. Does not fail the build if stubs have Clippy warnings, but does display them (and there are a number of them). The author of this PR is not sure we will ever get around to fixing all the Clippy warnings, but supposes that it is at least beneficial to make sure we add no new Clippy errors. 1/3 of #659 (By the way, ensure-stubs-compile already had a bad mix of spaces and tabs and this commit did not help any in making it better. The author's text editor cannot easily put tabs in shell scripts)
This reverts commit 7d41c0a.
This reverts commit f27d7e2.
This reverts commit b74f52b.
coriolinus
approved these changes
Nov 18, 2020
Member
|
WRT tabs and spaces. I hadn't noticed, but I would not object to a global replacement of tabs with spaces in our script files. |
This was referenced Nov 18, 2020
petertseng
added a commit
that referenced
this pull request
Nov 19, 2020
clippy::useless_format https://rust-lang.github.io/rust-clippy/master/index.html#useless_format Helps address #1011
petertseng
added a commit
that referenced
this pull request
Nov 20, 2020
It's understandable that clippy says the `next` here conflicts with Iterator's `next`, but I really think that's the best name for it unless we go with something like `forward` and `back`. There is one other example of Cursors on the internet: https://contain-rs.github.io/linked-list/linked_list/struct.Cursor.html This one also uses `next`, so it seems they did not find a better solution to this than we could. Helps address #1011 Helps address #1012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fails the build if any stubs have Clippy errors.
Does not fail the build if stubs have Clippy warnings, but does display
them (and there are a number of them).
The author of this PR is not sure we will ever get around to fixing all
the Clippy warnings, but supposes that it is at least beneficial to make
sure we add no new Clippy errors.
1/3 of #659
(By the way, ensure-stubs-compile already had a bad mix of spaces and
tabs and this commit did not help any in making it better. The author's
text editor cannot easily put tabs in shell scripts)
Here is the list of warnings emitted from all the stubs (well, each prints twice so you can probably consider each count halved)