DO NOT MERGE: tournament: don't bother writing the output file#153
Closed
petertseng wants to merge 1 commit intoexercism:masterfrom
petertseng:tournament-lol
Closed
DO NOT MERGE: tournament: don't bother writing the output file#153petertseng wants to merge 1 commit intoexercism:masterfrom petertseng:tournament-lol
petertseng wants to merge 1 commit intoexercism:masterfrom
petertseng:tournament-lol
Conversation
Since the output file is pre-provided, we don't need to write it, the test will just pass.
Member
Author
|
Tests pass. This means lazy implementations can get away with not writing files. We should not allow them. #154 will fix. Do not merge this PR. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the output file is pre-provided, we don't need to write it, the
test will just pass.