tournament: rm output files#154
Merged
petertseng merged 1 commit intoexercism:masterfrom Jul 3, 2016
petertseng:tournament-rm-output
Merged
tournament: rm output files#154petertseng merged 1 commit intoexercism:masterfrom petertseng:tournament-rm-output
petertseng merged 1 commit intoexercism:masterfrom
petertseng:tournament-rm-output
Conversation
With these output files present, implementation that do not actually write files will be able to pass the tests, defeating the purpose. See PR #153 for an example of such a lazy implementation. They were added in 65b691e in what I can only assume was an accident, since they were added long after the tournament exercise was added to this track in ee0a6fd.
Member
Author
Contributor
|
I'm fine with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these output files present, implementation that do not actually
write files will be able to pass the tests, defeating the purpose. See
PR #153 for an example of such a lazy implementation.
They were added in 65b691e in what I
can only assume was an accident, since they were added long after the
tournament exercise was added to this track in
ee0a6fd.