parallel-letter-frequency, tournament, word-count: Use Entry#or_insert#155
Merged
petertseng merged 4 commits intoexercism:masterfrom Jul 3, 2016
petertseng:or-insert
Merged
parallel-letter-frequency, tournament, word-count: Use Entry#or_insert#155petertseng merged 4 commits intoexercism:masterfrom petertseng:or-insert
Entry#or_insert#155petertseng merged 4 commits intoexercism:masterfrom
petertseng:or-insert
Conversation
This drastically shortens the function, avoiding the need to `match` on the `Entry` cases. This seems good to make the example more idiomatic.
This drastically shortens the `count` function and result collection loop in `frequency`, avoiding the need to `match` on the `Entry` cases. This seems good to make the example more idiomatic.
This drastically shortens the function, avoiding the need to `match` on the `Entry` cases. This seems good to make the example more idiomatic.
Member
Author
|
travis didn't pick this up for testing. kicking it. |
This drastically shortens the function, avoiding the need to `match` on the `Entry` cases. This seems good to make the example more idiomatic.
Member
Author
|
I also decided to make the change for |
Contributor
|
These are definitely more like the solutions I see being submitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These shorten the functions by removing the need to match on the
Entrycases.This seems good to make the examples more idiomatic.
Note the exercises that still match on
Entrycases but were not changed by this PR:grade-school: I judged that pushing an element onto the vector then sorting it was sufficiently different from creating a vector with a single element. I can be convinced otherwise.or_insertdoesn't make sense.