nucleotide-count: Use Entry#or_insert#186
Merged
petertseng merged 1 commit intoexercism:masterfrom Aug 24, 2016
petertseng:nucleotide-count
Merged
nucleotide-count: Use Entry#or_insert#186petertseng merged 1 commit intoexercism:masterfrom petertseng:nucleotide-count
Entry#or_insert#186petertseng merged 1 commit intoexercism:masterfrom
petertseng:nucleotide-count
Conversation
In #155, this operation was performed for other exercises (tournament, parallel-letter-frequency, word-count), but nucleotide-count was skipped because #149 indicates that invalid nucleotides maybe should produce errors. We don't need to wait for x-common to get a nucleotide-count.json before deciding to make the current implementation more idiomatic though. If it's eventually decided that `or_insert` doesn't make sense, we can change it then.
Contributor
|
ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #155, this operation was performed for other exercises (tournament,
parallel-letter-frequency, word-count), but nucleotide-count was skipped
because #149 indicates that invalid nucleotides maybe should produce
errors.
We don't need to wait for x-common to get a nucleotide-count.json before
deciding to make the current implementation more idiomatic though.
If it's eventually decided that
or_insertdoesn't make sense, we canchange it then.