Skip to content

Add stubs to some exercises#339

Merged
ijanos merged 7 commits intoexercism:masterfrom
leoyvens:more-stubs
Sep 1, 2017
Merged

Add stubs to some exercises#339
ijanos merged 7 commits intoexercism:masterfrom
leoyvens:more-stubs

Conversation

@leoyvens
Copy link
Copy Markdown
Contributor

@leoyvens leoyvens commented Aug 1, 2017

Add stubs to leap, raindrops, bob, beer song, proverb difference of squares and sum of multiples.

@ijanos
Copy link
Copy Markdown
Contributor

ijanos commented Aug 2, 2017

Can we modify Travis to check type check these? To approve this PR with a good conscience I would have to check every single type signature by hand.

Probably will open an issue/pull request if I got the time, but it is likely that someone will be faster than me.

@leoyvens
Copy link
Copy Markdown
Contributor Author

leoyvens commented Aug 2, 2017

I copy pasted all signatures from the example solutions so it's unlikely that they are incorrect, but I understand your concern. To make the manual review less painful here are the links to the examples:

beer song
bob
difference of squares
leap
proverb
raindrops
sum of multiples

@leoyvens
Copy link
Copy Markdown
Contributor Author

leoyvens commented Aug 6, 2017

This would be particularly useful to me if it could be merged before August 12 when I will be using Exercism at a Rust workshop. I'd really appreciate if someone managed to review before that!

@ijanos
Copy link
Copy Markdown
Contributor

ijanos commented Sep 1, 2017

Merging as this received no objections from anyone in a months time. Sorry for not making the merge before the 12th, I hope the workshop went well. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants