travis: Enforce that stubs compile, supporting commit (add unimplemented)#372
Merged
petertseng merged 2 commits intoexercism:masterfrom Oct 28, 2017
petertseng:check-stubs
Merged
travis: Enforce that stubs compile, supporting commit (add unimplemented)#372petertseng merged 2 commits intoexercism:masterfrom petertseng:check-stubs
petertseng merged 2 commits intoexercism:masterfrom
petertseng:check-stubs
Conversation
petertseng
changed the title
Member
Author
|
I had to expand this to have more. Individual commit messages explain. |
Member
Author
|
Sorry, but I am unable to effectively do my duties as a track maintainer (review others' PRs) without this being merged, so if I can't get a review in 24 hours I have to just test it myself and merge if it passes my own tests. |
petertseng
changed the title
petertseng
changed the title
Member
Author
|
OK, split up the other changes into other PRs. |
Member
|
Looks generally good to me! I think we'll need to add a |
Member
Author
|
|
Otherwise, the actual return type of the stubs do not match their declared return type and thus the stub does not compile.
Adding a stub with an incorrect signature would be confusing to students. We will prevent that with CI. Was desired in #339 (comment) Closes #371.
This was referenced Mar 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
travis: Enforce that stubs compile
Adding a stub with an incorrect signature would be confusing to
students. We will prevent that with CI.
Was desired in #339 (comment)
Closes #371.