macros: Allow stub to not compile#482
Merged
coriolinus merged 1 commit intoexercism:masterfrom Apr 4, 2018
petertseng:macros
Merged
macros: Allow stub to not compile#482coriolinus merged 1 commit intoexercism:masterfrom petertseng:macros
coriolinus merged 1 commit intoexercism:masterfrom
petertseng:macros
Conversation
The stub in fact does not compile and has never compiled ever since the exercise was added in #401. However, it is intentional that the stub does not compile, so we allow it not to. This was not caught by #372 because of #381 having tricked the Rust compiler into thinking it had already compiled the stub. This is required to be able to merge #483.
coriolinus
approved these changes
Apr 4, 2018
Member
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Good catch. Also, oops: it looks like this one is mostly my fault.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stub in fact does not compile and has never compiled ever since the
exercise was added in #401.
However, it is intentional that the stub does not compile, so we allow
it not to.
This was not caught by #372 because
of #381 having tricked the Rust
compiler into thinking it had already compiled the stub.
This is required to be able to merge
#483.