custom-set: Added template to the stub file#605
Conversation
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Looks great! Thanks for doing this. I'll plan to merge this on Wednesday.
|
|
||
| pub fn is_disjoint(&self, other: &Self) -> bool { | ||
| unimplemented!( | ||
| "Determine if the CustomSet struct and othe struct '{:?}' are disjoint.", |
There was a problem hiding this comment.
Spotted a typo othe struct should probably be the other struct. To reduce the noise, I would amend the fix to
the initial commit.
There was a problem hiding this comment.
Good spot! I missed that. Yes, please amend that into the single commit in this PR.
ZapAnton
force-pushed
the
custom_set_template
branch
from
0a4f51a to
1677ad2
Compare
|
Done. |
| phantom: PhantomData<T>, | ||
| } | ||
|
|
||
| impl<T: Debug> CustomSet<T> { |
There was a problem hiding this comment.
OK to add <T: Debug> here, since a T is used in so many unimplemented messages? Or should it be left out?
There was a problem hiding this comment.
The problem with the Debug trait bound seems to appear in a lot of exercises. Instead of having separate discussion in every PR, would you mind creating an issue about it? So that there would be one fixed solution.
3 participants
Contributes to #551