-
Notifications
You must be signed in to change notification settings - Fork 543
custom-set: Added template to the stub file #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,61 @@ | ||
| use std::fmt::Debug; | ||
| use std::marker::PhantomData; | ||
|
|
||
| #[derive(Debug, PartialEq)] | ||
| pub struct CustomSet<T> { | ||
| // This field is here to make the template compile and not to | ||
| // complain about unused type parameter 'T'. Once you start | ||
| // solving the exercise, delete this field and the 'std::marker::PhantomData' | ||
| // import. | ||
| phantom: PhantomData<T>, | ||
| } | ||
|
|
||
| impl<T: Debug> CustomSet<T> { | ||
| pub fn new(input: &[T]) -> Self { | ||
| unimplemented!( | ||
| "From the given input '{:?}' construct a new CustomSet struct.", | ||
| input | ||
| ); | ||
| } | ||
|
|
||
| pub fn contains(&self, element: &T) -> bool { | ||
| unimplemented!( | ||
| "Determine if the '{:?}' element is present in the CustomSet struct.", | ||
| element | ||
| ); | ||
| } | ||
|
|
||
| pub fn add(&mut self, element: T) { | ||
| unimplemented!("Add the '{:?}' element to the CustomSet struct.", element); | ||
| } | ||
|
|
||
| pub fn is_subset(&self, other: &Self) -> bool { | ||
| unimplemented!( | ||
| "Determine if the CustomSet struct is a subset of the other '{:?}' struct.", | ||
| other | ||
| ); | ||
| } | ||
|
|
||
| pub fn is_empty(&self) -> bool { | ||
| unimplemented!("Determine if the CustomSet struct is empty."); | ||
| } | ||
|
|
||
| pub fn is_disjoint(&self, other: &Self) -> bool { | ||
| unimplemented!( | ||
| "Determine if the CustomSet struct and the other struct '{:?}' are disjoint.", | ||
| other | ||
| ); | ||
| } | ||
|
|
||
| pub fn intersection(&self, other: &Self) -> Self { | ||
| unimplemented!("Construct a new CustomSet struct that is an intersection between current struct and the other struct '{:?}'.", other); | ||
| } | ||
|
|
||
| pub fn difference(&self, other: &Self) -> Self { | ||
| unimplemented!("Construct a new CustomSet struct that is a difference between current struct and the other struct '{:?}'.", other); | ||
| } | ||
|
|
||
| pub fn union(&self, other: &Self) -> Self { | ||
| unimplemented!("Construct a new CustomSet struct that is an union between current struct and the other struct '{:?}'.", other); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to add
<T: Debug>here, since aTis used in so manyunimplementedmessages? Or should it be left out?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with the
Debugtrait bound seems to appear in a lot of exercises. Instead of having separate discussion in every PR, would you mind creating an issue about it? So that there would be one fixed solution.