Skip to content

gigasecond:change chrono crate link#710

Merged
coriolinus merged 2 commits intoexercism:masterfrom
andy5995:change_chrono_link
Nov 13, 2018
Merged

gigasecond:change chrono crate link#710
coriolinus merged 2 commits intoexercism:masterfrom
andy5995:change_chrono_link

Conversation

@andy5995
Copy link
Copy Markdown
Contributor

When I used https://docs.rs/chrono/0.4.0/chrono/, the paragraph under
Duration has 3 dead links. Suggest changing this link to
https://crates.io/crates/chrono where the links under the Duration
section work.

@ZapAnton
Copy link
Copy Markdown
Contributor

Travis has failed, since the part that you have edited is auto-generated from the .hints file.
Please consider editing the .hints file and then running bin/configlet generate . -o gigasecond from the track root (the configlet utility could be downloaded with the bin/fetch-configlet.sh script).

Copy link
Copy Markdown
Member

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andy5995 for noticing this and contributing a fix! As @ZapAnton said, in order for this PR to pass CI, you're going to need to make your change in .meta/hints.md and then regenerate the README from there.

That said, once that's done and Travis passes, I don't anticipate any difficulty getting this merged.

I have suggested a change below, but my preference for that change is very mild. If you choose not to implement the change, that will not block acceptance of this PR.

Comment thread exercises/gigasecond/README.md Outdated
@andy5995
Copy link
Copy Markdown
Contributor Author

image

Because of that error, after changing .hints, I manually updated the README.

@ZapAnton
Copy link
Copy Markdown
Contributor

Sorry, forgot to mention that.

In order for configlet to regenerate the READMEs, the copy of the problem-specifications repo should be present in the file system, on the same level as this track repo.

So something like this should work:

cd ~/src
git clone https://github.com/exercism/problem-specifications
cd excercism-rust
bin/configlet generate . -o gigasecond

The above commands are not needed to pass the Travis check (it has already passed), but may be usefull in the future

@andy5995
Copy link
Copy Markdown
Contributor Author

The above commands are not needed to pass the Travis check (it has already passed), but may be usefull in the future

ok, got it!

@andy5995
Copy link
Copy Markdown
Contributor Author

I'm having a heckuva time with this exercise. First the problem with the dead duration links, then the stated goal, which I found vague:

Calculate the moment when someone has lived for 10^9 seconds.

But examining lib.rs and the tests cleared that up.

Now this: https://users.rust-lang.org/t/using-std-duration/22218

Anyway.. these comments are just feedback in case it's useful. I'll hopefully be able to finish this exercise after I get some more answers in my forum post.

When I used https://docs.rs/chrono/0.4.0/chrono/, the paragraph under
Duration has 3 dead links. Suggest changing this link to
https://crates.io/crates/chrono where the links under the Duration
section work.
Copy link
Copy Markdown
Member

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andy5995! Sorry you've been having trouble with this exercise, but it looks like the forum thread got you sorted.

Given that this PR is a pure documentation change, I will merge it immediately.

@coriolinus coriolinus merged commit 09b93a9 into exercism:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants