gigasecond:change chrono crate link#710
gigasecond:change chrono crate link#710coriolinus merged 2 commits intoexercism:masterfrom andy5995:change_chrono_link
Conversation
|
Travis has failed, since the part that you have edited is auto-generated from the .hints file. |
coriolinus
left a comment
There was a problem hiding this comment.
Thanks @andy5995 for noticing this and contributing a fix! As @ZapAnton said, in order for this PR to pass CI, you're going to need to make your change in .meta/hints.md and then regenerate the README from there.
That said, once that's done and Travis passes, I don't anticipate any difficulty getting this merged.
I have suggested a change below, but my preference for that change is very mild. If you choose not to implement the change, that will not block acceptance of this PR.
|
Sorry, forgot to mention that. In order for So something like this should work: cd ~/src
git clone https://github.com/exercism/problem-specifications
cd excercism-rust
bin/configlet generate . -o gigasecondThe above commands are not needed to pass the Travis check (it has already passed), but may be usefull in the future |
ok, got it! |
|
I'm having a heckuva time with this exercise. First the problem with the dead duration links, then the stated goal, which I found vague:
But examining lib.rs and the tests cleared that up. Now this: https://users.rust-lang.org/t/using-std-duration/22218 Anyway.. these comments are just feedback in case it's useful. I'll hopefully be able to finish this exercise after I get some more answers in my forum post. |
When I used https://docs.rs/chrono/0.4.0/chrono/, the paragraph under Duration has 3 dead links. Suggest changing this link to https://crates.io/crates/chrono where the links under the Duration section work.
coriolinus
left a comment
There was a problem hiding this comment.
Thanks @andy5995! Sorry you've been having trouble with this exercise, but it looks like the forum thread got you sorted.
Given that this PR is a pure documentation change, I will merge it immediately.
This helps address my comments in #710 (comment) exercism/problem-specifications#1398 exercism/problem-specifications#1404

When I used https://docs.rs/chrono/0.4.0/chrono/, the paragraph under
Duration has 3 dead links. Suggest changing this link to
https://crates.io/crates/chrono where the links under the Duration
section work.