Skip to content

gigasecond:add clarity to exercise goal#718

Merged
petertseng merged 1 commit intoexercism:masterfrom
andy5995:gigasecond_goal
Nov 22, 2018
Merged

gigasecond:add clarity to exercise goal#718
petertseng merged 1 commit intoexercism:masterfrom
andy5995:gigasecond_goal

Conversation

@andy5995
Copy link
Copy Markdown
Contributor

This helps address my comments in
#710 (comment)

@andy5995
Copy link
Copy Markdown
Contributor Author

Hmm.. failed 4/5 travis tests. Not sure why.

@ZapAnton
Copy link
Copy Markdown
Contributor

Travis has failed, because you modified the part of the README, that comes from the problem-specifications repo.

This section explains the problem.

@andy5995
Copy link
Copy Markdown
Contributor Author

@ZapAnton thanks for explaining. Is the change I suggested desired? If so, I'll modify the appropriate file in the other repo.

@coriolinus
Copy link
Copy Markdown
Member

The change you made here looks plausible to me, though there are a lot more moderators in the problem-specifications repo than there are here.

@andy5995
Copy link
Copy Markdown
Contributor Author

Submitted to the problem-specifications repo

@andy5995 andy5995 closed this Nov 15, 2018
@coriolinus
Copy link
Copy Markdown
Member

coriolinus commented Nov 15, 2018 via email

@andy5995 andy5995 reopened this Nov 15, 2018
@petertseng petertseng added the sync/readme Keep a README in sync with exercism/problem-specifications label Nov 20, 2018
@petertseng
Copy link
Copy Markdown
Member

Well, as you've now seen, that's what happens sometimes with problem-specifications. But this is a natural part of everyone wanting what's best for their track.

Now updated with the final version that resulted in problem-specifications, which means let's merge it.

@petertseng petertseng merged commit 9b072c4 into exercism:master Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sync/readme Keep a README in sync with exercism/problem-specifications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants