feat(v2): headings anchors#1385
Merged
yangshun merged 3 commits intofacebook:masterfrom Apr 24, 2019
radekmie:master
Merged
Conversation
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit 34a78a8 |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 34a78a8 |
endiliey
approved these changes
Apr 24, 2019
Contributor
endiliey
left a comment
endiliey
left a comment
There was a problem hiding this comment.
Overall LGTM 👍
Just few things:
- Lets add a hover property on the hash-link class like v1
- Any plan to add test ? Very useful to catch bugs
Contributor
|
@radekmie I made some changes, hope you don't mind:
I'm going to merge this first and release a version. The tests can come later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
An option to quickly copy a section link is essential!
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Check if headings have
#anchors with correctidset. Check if clicking right side TOC redirects correctly. Check if navbar is not covering the section after redirection from TOC.