Merged
Conversation
Contributor
|
Deploy preview for docusaurus-2 failed. Built with commit 0b6a094 https://app.netlify.com/sites/docusaurus-2/deploys/5cc096322150b3017dedccc1 |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 0b6a094 |
yangshun
reviewed
Apr 24, 2019
| transition: opacity 0.3s; | ||
| } | ||
|
|
||
| @media only screen and (min-width: 736px) { |
Contributor
There was a problem hiding this comment.
Why is this removed? This is for the hover behavior only on desktop widths since there's no hover on mobile.
Contributor
Author
There was a problem hiding this comment.
dank that was true :| i forget hover doesnt work on mobile
…nifest (facebook#1389) * fix(v2): use chokidar/fswatch instead of polling w timeout to wait client-manifest * refactor -> less code * DRY code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the hash-link is so hard to click.
See this gif or try it out at https://docusaurus-2.netlify.com/docs/installation/#launching-the-server-behind-a-proxy
Before I can click the hash, it already disappears
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Before
After
Related PRs
#1385