fix(v2): remove auto wrap for code blocks#2048
Merged
yangshun merged 1 commit intofacebook:masterfrom Nov 25, 2019
Merged
Conversation
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit 04ea648 |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 04ea648 |
endiliey
added
the
pr: polish
yangshun
approved these changes
Nov 25, 2019
Contributor
|
Hmmm. I feel that the layout is kinda unpleasant now. Previously it was like this |
This was referenced Nov 30, 2019
yangshun
pushed a commit
that referenced
this pull request
Nov 30, 2019
endiliey
removed
the
pr: polish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In v1, code blocks are displayed as is, without wrapping, in general, this is a very good UX, especially on mobile devices. This PR disables line wrapping instead of which scroll bar will be displayed.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Desktop:
Mobile: