Revert "fix(v2): remove auto wrap for code blocks (#2048)"#2071
Merged
Revert "fix(v2): remove auto wrap for code blocks (#2048)"#2071
Conversation
This reverts commit 10cd99b.
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit a4d9295 |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit a4d9295 |
Contributor
Author
|
We can close this if we find a solution. This is quite a temporary solution, because I was hoping to release alpha.37 soon since there has been too many commits already 😆 I do have another concern though. |
Contributor
|
Let's revert this first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As mentioned in #2056
and #2048 (comment)
I think it might be best to revert #2048 first. If we want to attempt on removing the codeblock autowrap, we can do it in new PR. Lot of changes has been added since alpha.36 and I think it'd be best to release soon so we can dogfood versioning & lot of other critical bugfix can land.
Because I'm seeing some unpleasant layout that is kinda zoomed and cut off. Notice the scrollbar
https://v2.docusaurus.io/docs/next/lifecycle-apis/
https://v2.docusaurus.io/docs/next/markdown-features
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
No longer zoomed
