feat(v2): support comments for code highlighting#2456
Merged
yangshun merged 6 commits intofacebook:masterfrom Mar 31, 2020
Merged
feat(v2): support comments for code highlighting#2456yangshun merged 6 commits intofacebook:masterfrom
yangshun merged 6 commits intofacebook:masterfrom
Conversation
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit 49319b2 |
Contributor
Author
|
I noticed some potential issues in the Gatsby implementation so I approached it a bit differently.
As I mentioned over in the issue, I've only added
|
|
OH THIS IS SO COOOOOOOL! :) I'm hyped. Can't wait to use this! |
docs(v2): demonstrate highlighting with comments
yangshun
approved these changes
Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Per #2271, this adds the ability to highlight lines using
highlight-next-line,highlight-start, andhighlight-endcomments.Supported comment syntax:
{ /* comment */ }//comment/* comment */# comment<!-- comment -->AFAIK most languages use at least one of these for comments.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
To test, use this markdown:
https://gist.github.com/elviswolcott/c4f15c6b0ec579e43a775cfdf9b25cc4
Related PRs
#2457 (docs)