Skip to content

docs(v2): demonstrate highlighting with comments#2457

Closed
elviswolcott wants to merge 1 commit intofacebook:masterfrom
elviswolcott:docs-comment-code-highlight
Closed

docs(v2): demonstrate highlighting with comments#2457
elviswolcott wants to merge 1 commit intofacebook:masterfrom
elviswolcott:docs-comment-code-highlight

Conversation

@elviswolcott
Copy link
Contributor

Motivation

Docs for #2456

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

n/a

Related PRs

#2456

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 8356ed1

https://deploy-preview-2457--docusaurus-2.netlify.com

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not document the new feature in a separate PR. Therefore could you move the changes from this PR to #2456, and close it?

@elviswolcott
Copy link
Contributor Author

Makes sense.
The current PR template language seems to suggest a separate PR for docs, I don't know if that should be updated. https://github.com/facebook/docusaurus/blob/master/.github/PULL_REQUEST_TEMPLATE.md#related-prs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants