fix(v2): fix missing logo in dark theme when darkSrc was not set#3784
Merged
slorber merged 1 commit intofacebook:masterfrom Nov 19, 2020
Merged
fix(v2): fix missing logo in dark theme when darkSrc was not set#3784slorber merged 1 commit intofacebook:masterfrom
slorber merged 1 commit intofacebook:masterfrom
Conversation
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit f0da9da |
Collaborator
|
thanks we'll release this very soon as it breaks the docusaurus init template on dark mode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
During the work on the
Logocomponent the fallback fordarkSrcwas removed (f49c56c).This do not affect the Docusaurus V2 website, but have caused an issue for sites using only
srcfield in logo config.Examples
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Changes has been tested locally using Docusaurus V2 website with
darkSrcremoved from the config 😉Related PRs