Added few lines for logo in dark theme#3797
Added few lines for logo in dark theme#3797yahu1031 wants to merge 1 commit intofacebook:masterfrom yahu1031:patch-1
Conversation
There is no description about dark theme logo. I added 2 to 3 lines which guide user to add `srcDark` in navbar.
|
Hi @yahu1031! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit d0e447c |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
slorber
added
the
pr: documentation
|
thanks ;) |
|
You documented the bootstrap theme, not the classic theme. Is it what you really wanted to do? I don't think the bootstrap theme is currently used by anyone as it's not production ready. |
uh oh! okie i will give it a try too. cause it is in development. 😉 |
|
Fixed the issue in #3784 |
4 participants
There is no description about dark theme logo. I have added 2 to 3 lines which guide user to add
srcDarkin navbar.Motivation
(Write your motivation here.)
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
As they are just documentation changes, I hope no need of test plan.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)